Configure VNC Port and Password #1174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking to add the ability to specify a port and password to be used when creating a VNC Graphics device. This has previously been requested in PR #706 and #698, but those went stale 5 years ago, and I doubt they're going to be resurrected. I went ahead and fixed merge conflicts and went through the recommendations holding up those PRs.
I believe all code, tests, and documentation are in order and I have tested this code and have confirmed it is working as intended. Please let me know what (if anything) needs to change before this can be merged. Thanks!